Update to use Polymer's properties-mixin #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2018 11:15
* _indvalidateProperties always triggers render. * remove bespoke `html`
TimvdLippe
reviewed
Jan 11, 2018
src/@polymer/polymer-lit-element.ts
Outdated
| export class PolymerLitElement extends PropertiesMixin(HTMLElement) { | ||
|
|
||
| ready() { | ||
| this.attachShadow({mode: 'open'}); |
There was a problem hiding this comment.
Given this line, I think we can add a shadowRoot: ShadowRoot as property on this class. This should remove the need for (el.shadowRoot as ShadowRoot) in every usage of this field.
There was a problem hiding this comment.
HTMLElement already has a shadowRoot property. It's just possibly undefined, so it needs a trailing ! modifier.
src/@polymer/polymer-lit-element.ts
Outdated
| export class PolymerLitElement extends PropertiesMixin(HTMLElement) { | ||
|
|
||
| ready() { | ||
| this.attachShadow({mode: 'open'}); |
There was a problem hiding this comment.
HTMLElement already has a shadowRoot property. It's just possibly undefined, so it needs a trailing ! modifier.
src/@polymer/polymer-lit-element.ts
Outdated
| // TODO(sorvell): propertiesChanged should have `_getData` | ||
| const result = this.render(this.__data); | ||
| if (result) { | ||
| render(result, this.shadowRoot as DocumentFragment); |
There was a problem hiding this comment.
render(result, this.shadowRoot!)
README.md
Outdated
| } | ||
|
|
||
| // Render method should return a `TemplateResult` using the provided lit-html `html` tag function | ||
| render(props, html) { |
README.md
Outdated
| } | ||
|
|
||
| // Render method should return a `TemplateResult` using the provided lit-html `html` tag function | ||
| render(props, html) { |
There was a problem hiding this comment.
Rather than props as an argument, I'd use destructuring:
render({foo}) {
return html`... ${foo}`;
}
demo/polymer-lit-element.html
Outdated
| super.ready(); | ||
| } | ||
|
|
||
| render(props) { |
src/@polymer/polymer-lit-element.ts
Outdated
|
|
||
| get nextRendered() { | ||
| if (!this._nextRendered) { | ||
| this._nextRendered = new Promise((resolve) => { |
There was a problem hiding this comment.
Later I think it'll be good to reject in case there's an exception during rendering. ie:
_flushProperties() {
super._flushProperties();
try {
const result = this.render(this.__data);
if (result) {
render(result, this.shadowRoot!);
}
} catch (e) {
if (this._nextRenderedReject) {
this._nextRenderedReject(e);
}
}
added 3 commits
January 16, 2018 16:21
* destructuring in render calls * avoid returning `nextRendered` in `invalidate` for now.
jbingham
added a commit
to jbingham/lit-element
that referenced
this pull request
Jan 29, 2019
"Made to share" and "Interoperable" seemed redundant. Fast/light is most valuable to users. Standards seems like lit#2.
justinfagnani
pushed a commit
that referenced
this pull request
Jan 31, 2019
"Made to share" and "Interoperable" seemed redundant. Fast/light is most valuable to users. Standards seems like #2.
bicknellr
pushed a commit
that referenced
this pull request
Jul 26, 2021
Add js-framework-benchmarks for lit-html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE, do not merge yet. Depends on Polymer 3.x being released on npm.